dblaikie added a comment. In D84244#2167661 <https://reviews.llvm.org/D84244#2167661>, @logan-5 wrote:
> In D84244#2167625 <https://reviews.llvm.org/D84244#2167625>, @hans wrote: > > > I don't really know why this doesn't happen with other warning flags, but I > > think it would be better to add flags like this with add_compile_options > > rather than add_compile_definitions. I imagine that would prevent it from > > reaching rc.exe. > > > That sounds pretty reasonable. Without any way of testing the Windows setup > myself though, I don't feel comfortable making that change. Sometimes it's OK to commit stuff an see how it goes on the buildbots - doing so out of peak times and with the intention of rolling back quickly/immediately if the buildbots report breakage is sometimes the best tool we have (not great, but such is the way of things). Alternatively @hans might be able to test it for you before that, or have other ideas/suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84244/new/ https://reviews.llvm.org/D84244 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
