MaskRay added inline comments.
================
Comment at: clang/test/Driver/hip-gz-options.hip:1
+// REQUIRES: clang-driver, x86-registered-target, amdgpu-registered-target
+
----------------
clang-driver is for some legacy cygwin stuff. It should not be needed.
Does --offload-arch=gfx906 have special requirement that the backend is needed?
For most other driver tests x86-registered-target is not needed to test `%clang
-target x86_64`
================
Comment at: clang/test/Driver/hip-gz-options.hip:12
+// CHECK: {{".*clang.*" .* "--compress-debug-sections=zlib"}}
+// CHECK-DAG: {{".*lld.*" .* "--compress-debug-sections=zlib"}}
+// CHECK-DAG: {{".*clang.*" .* "--compress-debug-sections=zlib"}}
----------------
Do the two patterns require `CHECK-DAG`?
================
Comment at: clang/test/Driver/hip-gz-options.hip:14
+// CHECK-DAG: {{".*clang.*" .* "--compress-debug-sections=zlib"}}
+// CHECK: {{".*ld.*" .* "--compress-debug-sections=zlib"}}
----------------
This ".*ld.*" needs to be removed as well
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87321/new/
https://reviews.llvm.org/D87321
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
