MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/test/Driver/hip-gz-options.hip:14
+// CHECK-DAG: {{".*clang.*" .* "--compress-debug-sections=zlib"}}
+// CHECK: {{"--compress-debug-sections=zlib"}}
----------------
Since this is no longer a regex you can remove the surround `{{` `}}`
================
Comment at: clang/test/Driver/hip-gz-options.hip:1
+// REQUIRES: clang-driver, x86-registered-target, amdgpu-registered-target
+
----------------
yaxunl wrote:
> MaskRay wrote:
> > clang-driver is for some legacy cygwin stuff. It should not be needed.
> >
> > Does --offload-arch=gfx906 have special requirement that the backend is
> > needed? For most other driver tests x86-registered-target is not needed to
> > test `%clang -target x86_64`
> This may be unnecessary. I will remove it.
>
> On the other hand, I think it requires zlib, so I will add zlib.
>
> Also I separated the test for target amdgcn from compress.c since it requires
> amdgpu-registered-target.
LG. clang-driver can still be removed
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87321/new/
https://reviews.llvm.org/D87321
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
