yaxunl added inline comments.
================ Comment at: clang/test/Driver/hip-gz-options.hip:1 +// REQUIRES: clang-driver, x86-registered-target, amdgpu-registered-target + ---------------- MaskRay wrote: > clang-driver is for some legacy cygwin stuff. It should not be needed. > > Does --offload-arch=gfx906 have special requirement that the backend is > needed? For most other driver tests x86-registered-target is not needed to > test `%clang -target x86_64` This may be unnecessary. I will remove it. On the other hand, I think it requires zlib, so I will add zlib. Also I separated the test for target amdgcn from compress.c since it requires amdgpu-registered-target. ================ Comment at: clang/test/Driver/hip-gz-options.hip:12 +// CHECK: {{".*clang.*" .* "--compress-debug-sections=zlib"}} +// CHECK-DAG: {{".*lld.*" .* "--compress-debug-sections=zlib"}} +// CHECK-DAG: {{".*clang.*" .* "--compress-debug-sections=zlib"}} ---------------- MaskRay wrote: > Do the two patterns require `CHECK-DAG`? only the middle two steps need CHECK-DAG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87321/new/ https://reviews.llvm.org/D87321 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits