salman-javed-nz added a comment. In D111208#3053370 <https://reviews.llvm.org/D111208#3053370>, @carlosgalvezp wrote:
> By the way, is `NOLINTBEGIN/END` expected to work/give errors when the check > name is something else than a real check name? See for example: > > https://godbolt.org/z/b6cbTeezs > > I would expect to get a warning that an `END` was found that didn't match a > `BEGIN`. The functions that we have been discussing in this patch only run when Clang-Tidy has detected a check violation and is about to print a warning about it. The `NOLINT` comment checks happen at the last minute. Since `foo` and `bar` are not real checks, Clang-Tidy won't find any violations, and so the `NOLINT` checks won't get the opportunity to run. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111208/new/ https://reviews.llvm.org/D111208 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
