vitalybuka created this revision. vitalybuka added reviewers: kda, eugenis. Herald added subscribers: usaxena95, kadircet, arphaman. vitalybuka requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits.
Even if findImplementors does not use uninitialized parameter it's still UB and it's going to be detected by msan with: -Xclang -enable-noundef-analysis -mllvm -msan-eager-checks=1 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116827 Files: clang-tools-extra/clangd/XRefs.cpp Index: clang-tools-extra/clangd/XRefs.cpp =================================================================== --- clang-tools-extra/clangd/XRefs.cpp +++ clang-tools-extra/clangd/XRefs.cpp @@ -1310,6 +1310,8 @@ QueryKind = RelationKind::BaseOf; } } + if (IDs.empty()) + return {}; return findImplementors(std::move(IDs), QueryKind, Index, *MainFilePath); }
Index: clang-tools-extra/clangd/XRefs.cpp =================================================================== --- clang-tools-extra/clangd/XRefs.cpp +++ clang-tools-extra/clangd/XRefs.cpp @@ -1310,6 +1310,8 @@ QueryKind = RelationKind::BaseOf; } } + if (IDs.empty()) + return {}; return findImplementors(std::move(IDs), QueryKind, Index, *MainFilePath); }
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits