vitalybuka added a comment. In D116827#3228594 <https://reviews.llvm.org/D116827#3228594>, @vitalybuka wrote:
> In D116827#3228524 <https://reviews.llvm.org/D116827#3228524>, @kda wrote: > >> This seems to introduce a new branch, should there be a new unit test in: >> XRefsTests.cpp? > > It's not functional change, test should not be able to see a difference after > this patch. to clarify: it's not realy new branch, as findImplementors already does exactly the same check. I considered removing that check, but it will complicated other callers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116827/new/ https://reviews.llvm.org/D116827 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
