kda added a comment.
This seems to introduce a new branch, should there be a new unit test in:
XRefsTests.cpp?
================
Comment at: clang-tools-extra/clangd/XRefs.cpp:1313
}
+ if (IDs.empty())
+ return {};
----------------
It seems like the first line of 'findImplementors' is 'if (IDs.empty() ||
!Index)`.
I wonder if the correct fix is to drop the '!Index' check in findImplementors.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116827/new/
https://reviews.llvm.org/D116827
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
