xbolva00 added a comment. Herald added a project: All. In D120305#3347191 <https://reviews.llvm.org/D120305#3347191>, @MaskRay wrote:
> In D120305#3347177 <https://reviews.llvm.org/D120305#3347177>, @nikic wrote: > >> Yes, because you reverted the change for that one buildbot, of course it is >> green now. You could have also made the buildbot green by disabling tests on >> that bot. Or disabling sanitizers on it. Doesn't change the fact that the >> configuration it was originally testing is still broken, you just hid the >> failure. > > > > In D120305#3347184 <https://reviews.llvm.org/D120305#3347184>, @tstellar > wrote: > >> In D120305#3347161 <https://reviews.llvm.org/D120305#3347161>, @MaskRay >> wrote: >> >>> In D120305#3347160 <https://reviews.llvm.org/D120305#3347160>, @nikic wrote: >>> >>>> @MaskRay Please revert the change and all dependent changes you have made. >>>> A revert is not a personal affront to you. It's not a judgement that you >>>> or your change are bad. It's a simple matter of policy and standard >>>> procedure. There's a good chance that next week you'll get confirmation >>>> that it's indeed some outdated libraries on the buildbot, and the change >>>> can reland without any changes on your side. Or maybe it turns out that >>>> this default is not quite viable for powerpc targets yet. Who knows. >>>> >>>> Don't worry about the churn. These short-term reverts happen all the time, >>>> we're used to it. Especially for tiny changes like this one, it's really >>>> no problem (reverts can be more annoying if the commit touches 1500 test >>>> files). >>> >>> I have mentioned that https://lab.llvm.org/buildbot/#/builders/57 has been >>> green. >> >> Disabling the failing tests with an unreviewed patch is not the right way to >> fix this. > > clang-ppc64le-rhel got `-DCLANG_DEFAULT_PIE_ON_LINUX=OFF` ~9 hours ago. If > any of you can make the configuration live on the bot, it will work and we > can re-enable the tests. https://lab.llvm.org/buildbot/#/builders/57 Somebody (@tstellar) should remove these powerpc shitty bots, red almost all the time as bot maintainers do nothing. There should be clear policy when to remove bad, broken, unmaintained bots. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120305/new/ https://reviews.llvm.org/D120305 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
