tstellar added a comment. In D120305#3347161 <https://reviews.llvm.org/D120305#3347161>, @MaskRay wrote:
> In D120305#3347160 <https://reviews.llvm.org/D120305#3347160>, @nikic wrote: > >> @MaskRay Please revert the change and all dependent changes you have made. A >> revert is not a personal affront to you. It's not a judgement that you or >> your change are bad. It's a simple matter of policy and standard procedure. >> There's a good chance that next week you'll get confirmation that it's >> indeed some outdated libraries on the buildbot, and the change can reland >> without any changes on your side. Or maybe it turns out that this default is >> not quite viable for powerpc targets yet. Who knows. >> >> Don't worry about the churn. These short-term reverts happen all the time, >> we're used to it. Especially for tiny changes like this one, it's really no >> problem (reverts can be more annoying if the commit touches 1500 test files). > > I have mentioned that https://lab.llvm.org/buildbot/#/builders/57 has been > green. Disabling the failing tests with an unreviewed patch is not the right way to fix this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120305/new/ https://reviews.llvm.org/D120305 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
