erichkeane added inline comments.
================ Comment at: clang/lib/Sema/SemaConcept.cpp:738 +public: + enum DepthAdjustmentKind { Diff, Value }; + ---------------- I don't really get what you're getting at with "Diff" and "Value"? Those names don't really seem to make sense to me? ================ Comment at: clang/lib/Sema/SemaConcept.cpp:779 + // The depths calculated for the declarations can be equal but they still + // may differ from the depths of types inside OldConstr and NewConstr. + OldConstr = ---------------- I don't believe they are supposed to, at least based on what you've said here. Can you clarify what you mean? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits