alexander-shaposhnikov added inline comments.

================
Comment at: clang/lib/Sema/SemaConcept.cpp:779
+    // The depths calculated for the declarations can be equal but they still
+    // may differ from the depths of types inside OldConstr and NewConstr.
+    OldConstr =
----------------
erichkeane wrote:
> I don't believe they are supposed to, at least based on what you've said 
> here.  Can you clarify what you mean?
i think I need to better understand what's going on here, because this is the 
culprit:
the calculated Depth1 and Depth2 are equal to 1 on our reproducer, thus no 
adjustments happen (in the old code), yet in the OldConst and NewConstr the 
depths are different.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146178/new/

https://reviews.llvm.org/D146178

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to