aaron.ballman added a comment. (I snipped off earlier context because it was starting to get hard to read.)
In D155809#4550727 <https://reviews.llvm.org/D155809#4550727>, @danlark wrote: > Okay, but I still don't understand how I can satisfy the following conditions > at the same time > > - Enable libc++ debug mode without failing existing tests like > llvm/llvm-project/clang/test/CodeGen:available-externally-hidden.cpp.test and > llvm/llvm-project/clang/test/CodeGenCXX:cxx2a-three-way-comparison.cpp.test > (yes, these are the tests that reach the assertion I am talking about). They > already exist. You can reproduce by building and running llvm-lit with libc++ > at head in debug mode. I'm ignorant of how things are tested within libc++ which may be contributing to the confusion here. https://github.com/llvm/llvm-project/blob/main/clang/test/CodeGenCXX/cxx2a-three-way-comparison.cpp does not include any header files, so I don't understand what libc++ has to do with the test. What I'm asking for is to add a clang-specific test that fires the assertion today (copied and reduced from whatever test code you've got in libc++ that demonstrates the issue) and no longer fires the assertion with your patch so that we can land the Clang changes. That should then allow you to enable the existing debug tests in libc++ without hitting the assertion from Clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155809/new/ https://reviews.llvm.org/D155809 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
