cor3ntin added a comment.

@danlark OH! It make sense now!
Thanks for the detailed explanation, having the whole context definitively 
helps understand the issue.

Clang is violating the `sable_sort` preconditions, and that is only observed in 
some standard library implementations.
In that light, the patch make sense, and I'm happy to accept it as is.

However, it might be interesting to enable LIBCPP_ENABLE_HARDENED_MODE on some 
build bots - I am assuming we already test to build clang with libc++ in a two 
stage bot somewhere. Is that something we could do @aaron.ballman ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155809/new/

https://reviews.llvm.org/D155809

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to