grigorypas wrote: > I'm not sure this design is really practical for users. Trying to make the > user count out the depth seems like it'll be difficult to use effectively: > it's hard to count, and the user has no direct control over which calls are > affected. And code refactoring is likely to break the intent. > > Could you describe a bit more what led you to this particular solution?
Thank you for your feedback and for raising these concerns. To clarify, our primary use case at Meta is to completely flatten functions by inlining the entire call tree. The max depth parameter is not intended as a core part of the user workflow, but rather as a safeguard to prevent issues if the call tree happens to be extremely deep. https://github.com/llvm/llvm-project/pull/165777 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
