HazardyKnusperkeks wrote: > > > Oh, I seem to have misunderstood the word "style" in the context of > > > clang-format. I took it to mean a concrete built-in style, like LLVM, > > > Google, Chromium, Mozilla, WebKit... > > > Am I wrong? > > > > > > It's not talking about a new style, but a new style option, and that is > > what you want to add. > > is it really better to have new forks appear, each user's own (usually > abandoned and unsupported), and incompatible with others? > > on the other hand, clang-format has a good verification system, allowing new > options to be added safely. > > P.S. I have 4 more new options =)
The thing is: * That rule is written in the documentation * It stands longer than I even know about clang-format * You want to remove spaces after comma and colon, which we never had before, the space before some of those tokens is configurable, but you want to add something completely new * I've never seen anyone doing something like that * This PR will lead to 4 times the possible formatting combinations * Which are obviously not tested So I think it's not too much if you could at least reply to the content. I've never said I wouldn't accept this PR, otherwise I wouldn't have provided feedback. But if you think a fork will help you, I won't stop you, and I also don't think it will hurt clang-format much. https://github.com/llvm/llvm-project/pull/190657 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
