jhuber6 wrote: > I'm not fundamentally opposed to this change but did you check why > `lto-partitions` caused issues exactly ? Do you have a reproducer ? Turning > splitmodule off by default is fine in theory but in this case it feels like > it's because there is a bug and instead of fixing the bug we just turn off > the feature so the bug is hidden. > > SplitModule should really not cause compilation problems. At best it could > increase binary size but it shouldn't cause correctness issues. Maybe it > handles some kind of calls wrong ?
Splitting modules fundamentally changes the uselist which is always going to change output. That's not something we should be doing by default for the user. The other issue associated with splitting this was the kernel descriptor metadata, which would be emit several duplicate and empty nodes. https://github.com/llvm/llvm-project/pull/203948 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
