Pierre-vh wrote:

> which is always going to change output

Output or behavior ? Does the observable program behavior change ?

> That's not something we should be doing by default for the user.

I don't have a strong opinion and I can see why it's a bad idea, yes.

> The other issue associated with splitting this was the kernel descriptor 
> metadata, which would be emit several duplicate and empty nodes.

Does it cause issues with the kernel descriptor ?

If there are issues with SplitModule that cause programs to become incorrect, 
then tickets/upstream issues should be filed before this lands.


https://github.com/llvm/llvm-project/pull/203948
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to