jhuber6 wrote: > Output or behavior ? Does the observable program behavior change ?
Yes, this was motivated by a regression dcsrgemm. You could probably mitigate that in other ways, but I still believe this should not be default. `-flto-partitions=8` is *extremely* annoying for debugging because it makes 8 temp files, and the number 8 is just a hand-waving guess at the number of threads the user has or would want. > Does it cause issues with the kernel descriptor ? Yes, I raised https://github.com/ROCm/rocm-systems/issues/3573 a long time ago and I don't think it's been fixed. I've also fixed issues like https://github.com/llvm/llvm-project/pull/187295 in the past. > If there are issues with SplitModule that cause programs to become incorrect, > then tickets/upstream issues should be filed before this lands. Hard disagree, doing this by default is bad even if it works perfectly fine. https://github.com/llvm/llvm-project/pull/203948 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
