brooksmoses added a comment.

Some further statistics, now that I've done a full cleanup on our code:

8 actual bugs newly found by -Wself-assign-field.  (Thank you!)
2 actual bugs newly found by -Wself-assign
6 instances of redundant code newly found by -Wself-assign
90 (approximately) instances of intentional self assignments in tests that now 
need "*&" annotations.

That seems like an awfully large amount of noise for the -Wself-assign part of 
this, and I continue feeling rather dubious about whether it should be part of 
-Wall.  By contrast, the -Wself-assign-field part has been entirely true 

  rC Clang

cfe-commits mailing list

Reply via email to