shuaiwang added a comment. In https://reviews.llvm.org/D45444#1068967, @Eugene.Zelenko wrote:
> In https://reviews.llvm.org/D45444#1068496, @shuaiwang wrote: > > > - I would imagine things could get messier if this check expands to also > > check for turning member functions const: it's basically checking > > CxxThisExpr, being a handle, is not modified within a member function, but > > note there's no VarDecl for "this". > > > Probably this should be separate check. See also PR21981. Sure, a separate check sounds better. Which makes even strong argument of having a reusable utility checking whether something is modified that can be shared between different checks :) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
