William McKee wrote:
On Fri, Oct 22, 2004 at 03:46:21PM -0400, Michael wrote:

Ok, here's another stab at this. I've include a test application module that I've been using to make sure stuff works together. Please look at the code, docs, test, etc and see if there is anything I might have left out.


Nice work, Michael. Those subroutines which do the header conversion are
indeed a bear. I've made some comments in the POD and attached a diff.
I'm interested to get your feedback on them.

I did change one line from your patch to read If you still want to use C<< header_props() >> or C<< header_add() >> remember that it will cause a performance hit because it will use helper routines that try and emulate L<CGI.pm|CGI>.

Since those methods don't use CGI and I dont implement those methods in my plugin, just _send_headers().

If you put this into a distribution, I'd be willing to help get testing
in place using Apache::Test[1].

That would be appreciated. I currently use Apache::FakeRequest in my CGI::Application::Dispatch module, but Apache::Test would be much better. I knew I'd have a good reason for learning it someday :)


--
Michael Peters
Developer
Plus Three, LP


--------------------------------------------------------------------- Web Archive: http://www.mail-archive.com/[EMAIL PROTECTED]/ http://marc.theaimsgroup.com/?l=cgiapp&r=1&w=2 To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to