On Fri, Oct 22, 2004 at 05:08:01PM -0400, Michael wrote: > I did change one line from your patch to read > If you still want to use > C<< header_props() >> or C<< header_add() >> remember that it will > cause a performance hit because > it will use helper routines that try and emulate L<CGI.pm|CGI>. > > Since those methods don't use CGI and I dont implement those methods in > my plugin, just _send_headers().
Ah, I see now. C::A is just storing values for us until the header is generated. Your performance hit probably isn't nearly as bad as loading up the full monty of CGI.pm. Too bad there isn't a way for you to subclass from one of the smaller CGI::* modules to get that ability to convert formats. > >If you put this into a distribution, I'd be willing to help get testing > >in place using Apache::Test[1]. > > That would be appreciated. I currently use Apache::FakeRequest in my > CGI::Application::Dispatch module, but Apache::Test would be much > better. I knew I'd have a good reason for learning it someday :) I'm a big convert of A::T. It's bar none the best test environment I've ever used. It allows you to test from both the client and server side which is very cool. It has support for Module::Build and some support for Test::More (on the client side). I strongly recommend reading over Geoff's article[1] if you want to learn more (it's a bit old but still relevant). Send over a tarball when you're ready for me to roll in the tests. William [1] http://www.perl.com/pub/a/2003/05/22/testing.html -- Knowmad Services Inc. http://www.knowmad.com --------------------------------------------------------------------- Web Archive: http://www.mail-archive.com/[EMAIL PROTECTED]/ http://marc.theaimsgroup.com/?l=cgiapp&r=1&w=2 To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
