[ 
https://issues.apache.org/jira/browse/CMIS-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869674#action_12869674
 ] 

Dave Landers commented on CMIS-210:
-----------------------------------

When the servlet retrieves the url query parameter with       
     String browseUrl = req.getParameter(PARAM_URL);
it is unencoded by the HttpServletRequest implementation.

So for symmetry, it seems that the entire query param should be encoded when 
the href's are generated (by the xsl).

Doing this encoding and allowing the request to decode, the browseUrl will 
receive the exact same thing as the repository provided in its link.

It is possible that then the issue is the section in the servlet which is 
commented "re-encode parameters"?  This seems like it is doing the extra 
encoding - and too late, too (link parameters have already been lost unless the 
entire url param is encoded)?

> test browser links need url encoding
> ------------------------------------
>
>                 Key: CMIS-210
>                 URL: https://issues.apache.org/jira/browse/CMIS-210
>             Project: Chemistry
>          Issue Type: Bug
>          Components: opencmis-test
>            Reporter: Dave Landers
>            Priority: Minor
>         Attachments: browser_xsl_encoding.zip
>
>
> Links in the browser are not working with our CMIS repo (Oracle) as the url 
> query param is not encoded (so query params on our links - especially paging 
> links next/previous/first/last - are being lost)
> All the link and collection href's in the browser's xsl need to be encoded so 
> they forward to the repository properly.
> I have a potential fix for entry.xsl, feed.xsl, and service.xsl I would be 
> happy to contribute

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to