[
https://issues.apache.org/jira/browse/CMIS-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869745#action_12869745
]
Dave Landers commented on CMIS-210:
-----------------------------------
That did solve the above issue with query params.
However I still have one repository (an older implementation) that does still
have a somewhat different issue. That repo puts the ids in the URI path rather
than in a query param, and some of our IDs contain slashes. So the equivalent
to the uris I gave before is more like
http://repo/children/IDC:Folder%2F4
and for that repo the encoding of the %2F is important, as it is not a path
separator but an id character.
With your latest fix this hasn't changed, as the %2F is unencoded into a '/'
and that confuses our resource impl.
But this encoded slash issue has caused us problems with proxies and things
(which is exactly what the test browser is, really). So for our cmis-1.0
implementation we are moving away from this and putting the ids in a query
param, where the encoding is less an issue.
If I use my xsl fix and remove the "re-encode parameters" section and leave the
req.getParameter(PARAM_URL) as it was before - that will work with both of my
repo versions.
I am ok with your fix as it works with our latest repository version. But I
bring up the issue with my older repo just because it might also affect other
vendor implementations? I'll leave that your call.
The one thing I do like about your fix vs. mine is that I can actually read the
URIs on the links in my browser location bar without having to run my in-brain
decoder - which doesn't work very well :)
> test browser links need url encoding
> ------------------------------------
>
> Key: CMIS-210
> URL: https://issues.apache.org/jira/browse/CMIS-210
> Project: Chemistry
> Issue Type: Bug
> Components: opencmis-test
> Reporter: Dave Landers
> Priority: Minor
> Attachments: browser_xsl_encoding.zip
>
>
> Links in the browser are not working with our CMIS repo (Oracle) as the url
> query param is not encoded (so query params on our links - especially paging
> links next/previous/first/last - are being lost)
> All the link and collection href's in the browser's xsl need to be encoded so
> they forward to the repository properly.
> I have a potential fix for entry.xsl, feed.xsl, and service.xsl I would be
> happy to contribute
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
