On Fri, 29 Jun 2012 20:49:49 +0200 Peter Bex <[email protected]> wrote:
> On Thu, Jun 28, 2012 at 10:25:11AM -0400, Mario Domenech Goulart wrote: >> >> The attached patch contains a fix to #869 >> (https://bugs.call-cc.org/ticket/869). >> >> srfi-13.scm is compiled with (declare (fixnum)), but `xsubstring' and >> `string-xcopy!' use / in a cond clause as a shorter path to avoid >> calling `%multispan-repcopy!', which is more "expensive". >> >> The patch just removes that shorter path, so the fixnum declaration can >> be kept. > > Excellent, I've pushed this, Thank you. > but I still think we should consider pulling in the tests. Now we > just have this fix without a regression test, it might creep back in > if we ever decide to rewrite parts of SRFI-13 (as its performance > really is suboptimal in general we probably want to consider doing > this some day...) You are right. I'm gonna port the BSD-licensed part of https://github.com/mario-goulart/chicken-tests/blob/master/tests/srfi-13.scm (from Gauche) and provide a patch. Best wishes. Mario -- http://parenteses.org/mario _______________________________________________ Chicken-hackers mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/chicken-hackers
