On Tue, Oct 21, 2008 at 11:44 AM, Ken Berry <[EMAIL PROTECTED]> wrote: > It would be useful to improve the functions where possible when they > are encapsulated, but I do not think the details of GetLastError() are > really the point of the message.
It does have some bearing on how fine-grained per-platform code should be, however. In this case, just wrapping the WIN32 call does not do much good, since the whole "get last error" idea (and surrounding logic) is pretty Windows-specific. Rather than wrapping GetLastError, it's worth looking at what calls it, and making it more generic. GetLastError and errno are similar, but can't actually be used interchangeably--so wrapping down at that layer doesn't actually remove any platform-specific logic. Going further, what we specifically do not want to do is end up with a "windows emulation library" that implements Windows assumptions about the OS. Now, there are indeed a few places where essentially the same functionality exists on all platforms under slightly different names (or parameter variations, etc.). In those cases we've been putting a wrapper into base. --Amanda --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~----------~----~----~----~------~----~------~--~---
