On Thu, Oct 23, 2008 at 12:28 AM, Amanda Walker <[EMAIL PROTECTED]> wrote: > > On Wed, Oct 22, 2008 at 2:11 PM, Ibrar Ahmed <[EMAIL PROTECTED]> wrote: >> You can see we have to make partial tables for each call of >> GetLastError(). So its better to make general error conversion table, >> because these partial conversion on every call of GetLastError really >> create a mess in a code. > > The effects extend further than this, though. Not all errors have > equivalents on other platforms, and the proper response to even ones > that do may also differ (for example, see some of the SSL code, where > otherwise platform-neutral code had to be refactored to handle > differences between how different SSL implementations report status > and error information).
Hmm, true I agreed with you here in SSL. My option will work on some places not on every place. So I am backing off with my option. Sorry for the noise :(. > Often, a better solution is to have a thicker platform-specific layer > that encapsulates more than just return values and parameters, since > those often don't actually map to across platforms perfectly. > Going back to the start of this thread... maybe talking about > specifics will help. > > What Windows stuff were you running into lots of calls to > GetLastError() in? Wrapping just that call might help get things to > compile, but is the surrounding logic optimal for Linux as well, or > would a bit more refactoring be a better answer? Actually I am working/reading "net module"; in this area my option is more suited (except ssl) than other modules. > --Amanda > > > > -- Ibrar Ahmed EnterpriseDB http://www.enterprisedb.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~----------~----~----~----~------~----~------~--~---
