Since std::wstring isn't always necessary, I'm looking at adding std::string support to Value (base/values.h).
There are four ways to go about it, in order of increasing number of changes: 1) Overload CreateStringValue, GetAsString, etc.. to also accept std::string. Add TYPE_UTF8_STRING to ValueType enum. 2) Overload CreateStringValue, GetAsString, etc.. to also accept std::string. TYPE_STRING becomes TYPE_WIDE_STRING and TYPE_STRING refers to std::string. 3) Change CreateStringValue, GetAsString to work with std::string, add CreateWideStringValue, GetAsWideString for std::wstring 4) Change CreateStringValue, GetAsString to work with std::string, remove std::wstring completely and refactor all the code to work with UTF-8 strings. I'm in favour of #2, but I'm not opposed to #3 since the code will be easier to grep. Suggestions? Andrew --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~----------~----~----~----~------~----~------~--~---
