Darin touched upon this, who said to document that std::string should refer to UTF-8 strings. How about: - CreateStringValue creates a StringValue object that returns TYPE_UTF8_STRING and has a DCHECK(IsStringUTF8(foo)) in the constructor - CreateWideStringValue creates a WideStringValue object that returns TYPE_UTF16_STRING
On Mon, Dec 8, 2008 at 6:07 PM, Peter Kasting <[EMAIL PROTECTED]> wrote: > On Mon, Dec 8, 2008 at 5:28 PM, Andrew Scherkus <[EMAIL PROTECTED]>wrote: > >> 1) Overload CreateStringValue, GetAsString, etc.. to also accept >> std::string. Add TYPE_UTF8_STRING to ValueType enum. >> 2) Overload CreateStringValue, GetAsString, etc.. to also accept >> std::string. TYPE_STRING becomes TYPE_WIDE_STRING and TYPE_STRING refers to >> std::string. >> > > Are narrow strings always going to be UTF-8? If so, maybe TYPE_UTF8_STRING > and TYPE_UTF16_STRING (or is it TYPE_UCS2_STRING?) make the most sense? It > would be nice to be explicit. > > PK > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~----------~----~----~----~------~----~------~--~---
