On Tue, Dec 9, 2008 at 1:17 PM, <[EMAIL PROTECTED]> wrote: > > I think it would be ok to have GetString and GetAsString both be > overloaded to work with std::string and std::wstring while we transition > the callers. It's the same as having a single CreateStringValue that > takes std::string and std::wstring. > > Having 2 string types is really confusing and I think it will introduce > bugs where people mean to check both but only check one.
I think I'm shifting to this viewpoint. Seems like just having one string type is what we want, and under the hood that type should be represented as UTF-8. I don't care much on the issue of whether we only provide a narrow getter, versus providing an "AsWString" getter alongside it (the latter seems like it'd be useful unless we think almost no callers should ever need this). PK --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~----------~----~----~----~------~----~------~--~---
