On Tue, Dec 9, 2008 at 1:58 PM, Andrew Scherkus <[EMAIL PROTECTED]> wrote: > Looking through some of the code again it gets a bit scary when there's code > checking for TYPE_WSTRING but not the other. > So how about: > CreateStringValue accepts std::string and std::wstring > SetString accepts std::string and std::wstring > GetString can return std::string or std::wstring and uses lazy conversion > when needed > > We can remove the overloaded std::wstring versions when clients switch over > to std::string.
Sorry to contribute to this bikeshed, but: my experience with hoping that clients will fix themselves has been that it'll never happen. Is it really so hard to globally replace callers to call a GetWString version? --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~----------~----~----~----~------~----~------~--~---
