On Thu, Apr 23, 2009 at 4:35 PM, Nikita Ofitserov <[email protected]> wrote: > Currently there are different implementations of ProcessSingleton and > ChromeBrowserProcessId() on Windows, Linux and Mac. Most of them are > quite hacky, so there should be a better way. I think current IPC > system with slight modifications can replace them all.
"Hacky" is fairly subjective: are there particular things about the existing implementation that bother you? Currently they are different for each OS because each OS has its own issues surrounding launching multiple instances of the browser, different mechanisms for handling incoming requests from the OS to open web pages, and so on. > This eliminates all differences between platforms in > process_singleton_* and chrome_process_util_*. > What do you think? But it also has additional costs compared to the current implementations: new race conditions, more error handling required to clean up stale files, more disk I/O at application startup, etc. Is there a significant corresponding benefit? Simply eliminating differences between per-platform implementations is not necessarily a large benefit by itself, since the amount of code is small and concerns an area where the three platforms behave quite differently. --Amanda --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
