On Mon, Apr 27, 2009 at 8:05 AM, Mike Pinkerton <[email protected]> wrote: > > On Sun, Apr 26, 2009 at 5:50 PM, Amanda Walker <[email protected]> wrote: >> Application startup is one of the areas where we count every >> millisecond, and try to touch the disk as little as possible. I don't >> think it's safe to assume that the cost of creating and writing to a >> file is negligible in this context without actually measuring it. > > Just curious, how many files are read/written loading a profile: > history, bookmarks, cache, last session, preferences, cookies, etc? I > imagine it's non-trivial and happens at every startup.
Cache is loaded synchronously on the I/O thread, along with the cookies. The history is loaded asynchronously on the history thread. The bookmarks are loaded asynchronously on the file thread and passed to the UI thread. The only things loaded synchronously are the ones we have to have to continue, which are the preferences and, when "open the last session" is set in the preferences, the session file. > I agree that the proposal just for the sake of consolidating code may > not be warranted, but to jump all over it because a file has to be > written seems like premature optimization in light of everything else > that happens on the disk at app startup. We start up significantly faster than any other browsers because we worry about this stuff. When the disk is thrashing (like right after you start your computer) there will be an even larger difference. Brett --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
