Salut again, I finally got it all working well on Windows (at least as far as I can see), and the numbers seem to say that this optimization would compensate for the slow down that was introduced when the resizer corner was enabled...
I still have some doubts about the validity of the numbers I get on my machine, so please try it out if you have ways to consistently get similar profiling numbers on your machine... Also, please look at the code to make sure I don't do anything foolish in there... You can find it here: http://codereview.chromium.org/108040. Note that this still only works on Windows... I will start doing the changes to make it also work on Mac and Linux this afternoon... Once I get my post-lunch latté :-) Enjoy! BYE MAD :-) On Mon, May 11, 2009 at 8:44 PM, Marc-Andre Decoste <[email protected]>wrote: > Feel free to ping <del>me</del> agl if you need help on Linux. ;) >> > > Will do... thanks for the offer :-) > > BYE > MAD > > On Mon, May 11, 2009 at 8:42 PM, Evan Martin <[email protected]> wrote: > >> >> On Mon, May 11, 2009 at 5:40 PM, Marc-Andre Decoste <[email protected]> >> wrote: >> >> However, I think that means if you leave the TransportDIB as the union >> >> >> >> of all the dirty rects, everything should Just Work. So your change >> >> >> >> becomes sending one unioned dirty rect image of pixel data, some of >> >> >> >> which that may not have actually been drawn to, along with an array of >> >> >> >> "actually dirty" subrectangles within the image. >> > >> > This is exactly what I'm doing on Windows... The receiving side loops on >> the >> > dirty sub-rectangles and get their pixels from the single btimap being >> > sent... And this bitmap is "only" valid in the areas of the >> sub-rectangles >> > passed in a vector via IPC. >> > Are we saying the same thing here? >> >> Yes. >> >> > P.S.: I'm still validating that it is all OK on the Windows side, just >> fixed >> > what I hope was the last refresh bug with Google maps, and then, I'll >> update >> > the GTK and Coco version of the painting code... >> >> Feel free to ping <del>me</del> agl if you need help on Linux. ;) >> >> >> >> > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
