2009/6/18 Jeremy Orlow <jor...@google.com>

> I actually had this problem _before_ this change.  Guess I should have
> brought it up, but I figured it was just something funny on my system.
>

I, too, had this problem (theme.dll not being built) _before_ this change
and I didn't bring it up for the same reason as Jeremy ;-)

Also, when I use increbuild (this is again before the change. and I haven't
updated my tree after sgk's checkin) to do a clobber-build, header files
supposed to be generated out of grd are not generated and I have to build
related projects manually.

Jungshik


>
> On Thu, Jun 18, 2009 at 2:21 PM, John Abd-El-Malek <j...@chromium.org>wrote:
>
>> +1 this is affecting a lot of people.
>>
>>
>> On Thu, Jun 18, 2009 at 12:43 PM, Daniel Cowx <daniel.c...@gmail.com>wrote:
>>
>>>
>>> I notice that when I load chrome.sln and do a build, not all the
>>> dependencies are built anymore. For instance, theme_dll isn't built
>>> (not listed in the proj deps), is this expected?
>>>
>>> On Jun 18, 12:38 am, Steven Knight <s...@chromium.org> wrote:
>>> > Okay, it looks like this change is sticking, at least until someone
>>> > discovers Yet Another Unintended Side Effect.  So heed the warnings in
>>> the
>>> > previous message, quoted below.
>>> > Git users on Linux:  this requires an update to gyp to work properly,
>>> so
>>> > make sure you "gclient sync" after you "git pull", or whatever the
>>> right
>>> > combination of commands is.  If you see Python stack traces from gyp
>>> > accompanied by complaints about looking up a "Dir as a File", make sure
>>> the
>>> > tools/gyp subdirectory is at r521.
>>> >
>>> >         --SK
>>> >
>>> >
>>> >
>>> > On Wed, Jun 17, 2009 at 9:25 PM, Steven Knight <s...@chromium.org>
>>> wrote:
>>> > > Heads up, again, dept.:
>>> > > In the next in an ongoing series of attempts to convert chrome.exe to
>>> gyp,
>>> > > I'm going to (try to) land two changes now that you should be aware
>>> of:
>>> >
>>> > > 1)  convert the 'app' target in the chrome.gyp file to being named
>>> > > 'chrome'. 2)  actually convert the 'chrome_exe' project to using a
>>> > > gyp-generated chrome.vcproj file, instead of the checked-in one.
>>> >
>>> > > When the first change lands, Mac developers will need to look for the
>>> new
>>> > > 'chrome' target instead of 'app', and Linux developers who have been
>>> typing
>>> > > 'hammer app' (or 'make app' if you're using the Makefile generator)
>>> will
>>> > > need to type 'hammer chrome' ('make chrome').  The default behaviors
>>> of
>>> > > building everything should be unaffected.
>>> >
>>> > > When the second change lands, Visual Studio users will need to use
>>> the
>>> > > 'chrome' project, instead of the former 'chrome_exe' project.  NOTE:
>>> > >  because the underlying .vcproj file will be completely different,
>>> any local
>>> > > settings you've configured into the old 'chrome_exe' project will NOT
>>> be
>>> > > transferred to the new 'chrome' project.  You'll have to make a note
>>> of any
>>> > > custom settings before updating and re-apply them to the new 'chrome'
>>> > > project.
>>> >
>>> > > There's always the chance that one or both of these changes will have
>>> to be
>>> > > reverted if unintended side effects pop up.  I'll send out confirming
>>> email
>>> > > with the final state of things.
>>> >
>>> > >         --SK
>>>
>>>
>>
>>
>>
>
> >
>

--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
    http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to