>>> platform/graphics/chromium/FontPlatformDataLinux.cpp: >>> >>> (WebCore::FontPlatformData::setHinting): >>> (WebCore::FontPlatformData::setAntiAlias): >>> (WebCore::FontPlatformData::setSubpixelGlyphs): >>> (WebCore::FontPlatformData::setupPaint): Modified to do something super >>> special. >>> platform/graphics/chromium/FontPlatformDataLinux.h: >> >> Is it worth putting this into the change list? If so, maybe 'gcl commit' >> can do it (since doing it any earlier risks it getting stale as the CL >> changes). > > The benefit of this is that you can give more detailed comments inline. You > see some WebKit commits do this (e.g. Darin Adler's) and it makes it much > more clear from reading the change description what happened. So, if we're > going to do it, it's not useful to do at commit time. It would be great if > people got in the habit of writing detailed descriptions like this.
I am against ... oh, PK already responded and said exactly what I was gonna say. If there are notes that are relevant to some bit of code, they belong as comments beside the code. --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
