Great! Please try to add this to an existing check, or do it in a way that doesn't involve the files being read once for each presubmit check, as the presubmit step is already too slow.
On Thu, Aug 20, 2009 at 11:16 AM, Paweł Hajdan Jr. <[email protected]>wrote: > Cool! Thanks so much. I'm going to write a presubmit check for that. > > On Thu, Aug 20, 2009 at 11:12, John Abd-El-Malek <[email protected]> wrote: > >> Including files like render_messages.h and automation_messages.h from >> other header files is unnecessary and slows down the build (adds about ~100K >> lines of headers to each cc file). Last time I removed all these >> occurrences, it improved the build time by 15%. Looks like a few more >> crept in now, so I'm removing them. Please be careful not to reintroduce >> this, and look out for this in code reviews (yes, it would be great to have >> an automated way of catching this, patches welcome). >> >> >> > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
