On Sat, Aug 22, 2009 at 7:49 PM, Jeremy Orlow <jor...@chromium.org> wrote:
> On Sat, Aug 22, 2009 at 5:54 PM, Peter Kasting <pkast...@chromium.org>wrote:
>
>> Notes in test_expectations.txt are like comments in source code: A great
>> boon.
>>
>
> I've herd differing opinions, but you're the definitely the most gung-ho
> I've talked to about notes in the test_expectations.txt file. Typically
> bugs are where most if not all of the information on failures should be
> kept. If there is information in the test_expectations.txt file, it should
> certainly be a subset of the information in the bugs, would you not agree?
>
Yes, that is ideal. One nice thing about comments in the test_expectations
file is that unlike comments in bugs, they're (a) hard to miss and (b)
unlikely to be drowned by a sea of bugdroid comments and other spew. Also,
frequently tests with completely different failures get grouped into one bug
("merge failures r1-r2") and comments on the tests can help add clarity
(although splitting these into multiple bugs is also advisable).
PK
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
