On Thu, Sep 10, 2009 at 10:19 AM, Paweł Hajdan Jr. <[email protected]> wrote: >> In this case, the code may have been submitted by a committer >> without using the trybots (tsk, tsk). We don't currently mention >> the trybots on dev.chromium.org. Is it time to? > > Submitting without trybots and breaking the compile? Doesn't look good to > me. I think we should mention that all committers should use the trybots > (they have access to them).
I see we do talk about the trybots on dev.chromium.org, so I changed http://sites.google.com/a/chromium.org/dev/developers/contributing-code as follows: Added new line: # If you can commit, run your changes through the try server before committing to reduce the chances your change will break the build on some other platform. (where try server is a link to http://dev.chromium.org/developers/try-server-usage) Added *new text* in old line: # If you can't commit, ask the reviewer to commit your fix for you. They will patch their working copy with your changelist, *run it through the try server,* and commit it for you. Added *new text* in old line: # Once you've checked something in, you're on the hook for making sure the BuildBot waterfall stays healthy, so stick around and watch them until everything cycles green. If you break something, you have to fix it, *even if it's on a different platform*. That sound ok? --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
