OK, we should probably improve http://dev.chromium.org/developers/contributing-code similarly, then.
In this case, the code may have been submitted by a committer without using the trybots (tsk, tsk). We don't currently mention the trybots on dev.chromium.org. Is it time to? On Thu, Sep 10, 2009 at 10:07 AM, Paweł Hajdan Jr.<[email protected]> wrote: > For me it was obvious, but if people are surprised by this, then improving > the documentation is probably a good idea. > Just curious... the change has been submitted to trybots before landing, > hasn't it? > > On Thu, Sep 10, 2009 at 10:03, Dan Kegel <[email protected]> wrote: >> >> An external contributor was recently surprised that a change tested >> on linux was reverted because it broke the build on windows. >> (His mental model was that linux developers don't have to >> worry about other platforms, that's what windows developers are for.) >> He said that none of the doc at dev.chromium.org covered this, so I had a >> look. >> >> http://dev.chromium.org/developers/core-principles >> lists four core categories: Speed, Security, Stability, and Simplicity. >> Under Stability, it says >> >> "We try to write as many automated tests as we can, to make sure that >> the product is still functioning as intended. We close the tree when >> the tests fail. We revert changes that break them." >> >> That seems to cover it, but it is a bit buried, and it doesn't >> really announce our commitment to full support of all three >> platforms. >> >> Anyone think we need to add some text that emphasizes that developers need >> to worry about more than just their own platform? >> >> >> > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
