Still, I'd find that worrying that we have a 42% perf regression in trunk.
But you're using sunspider, which is mostly **** anyway (personal opinion). Are you using a laptop? It greatly influences the timing of this test. M-A On Fri, Sep 18, 2009 at 5:56 AM, PhistucK <[email protected]> wrote: > Sorry! replace that with 195! > ☆PhistucK > > > On Fri, Sep 18, 2009 at 00:10, Rozenkraft <[email protected]> wrote: >> >> Ok, it makes sense now, sorry. I was confused because Phistuck >> mentioned 196 when >> I expected 195. In that case, just a problem remaining: how do I know >> the branch? >> Upon examination of the branches I would expect the right branch to be >> 195, as I said, >> (because it was last updated the day before the release) but PhistucK >> says it's 196 >> which was updated 11 days ago. So, how am I supposed to know this? >> >> On Sep 17, 10:44 pm, Thomas Van Lenten <[email protected]> wrote: >> > On Thu, Sep 17, 2009 at 4:41 PM, Rozenkraft <[email protected]> >> > wrote: >> > >> > > > The corresponding revision is not the right revision.Did you try to >> > > > sync >> > > > your Chromium source code to the 196 branch? This is the source code >> > > > used >> > > > for the 3.x release, not the corresponding revision you mentioned. >> > > > Many >> > > > improvements, code and bug fixes were merged into the branch after >> > > > that >> > > > revision, so it is not the right one to sync to. >> > > > The branch is available here - >> > >http://src.chromium.org/viewvc/chrome/branches/196/ >> > >> > > I downloaded the chrome I wanted to compare to (Stable 3.0.195.21). >> > > Then >> > > visited about:version, looked at the revision number, 26042, and >> > > synced to >> > > that revision with gclient sync --revision s...@26042. >> > >> > > So, are you saying that about:version is unreliable cause Google >> > > manually adds >> > > patches after syncing? *confused* >> > >> > No, the revision is right, but that doesn't say what build directory >> > kicked >> > it all off. We don't build releases off the trunk, instead they are off >> > a >> > branch (http://src.chromium.org/viewvc/chrome/branches/), so you need to >> > use >> > the information in right branch at that revision. >> > >> > TVL >> > >> > >> > >> > >> > > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
