I'll fix gcl try to also do 2-sided patches in a single command like git-try does. Should be an easy port.
On Thu, Sep 24, 2009 at 2:25 PM, Drew Wilson <[email protected]> wrote: > Why the snark? Is it inappropriate to point out pain points in a proposed > process without attaching a patch to my email? > As someone who happily spent an hour+ yesterday tracking down an obscure > bug in trychange.py, I don't think I'm someone who just sits on the > sidelines making work for other people. > > -atw > > On Thu, Sep 24, 2009 at 2:20 PM, Marc-Antoine Ruel <[email protected]>wrote: > >> Thanks for proposing yourself in improving gcl.py and trychange.py. >> >> On Thu, Sep 24, 2009 at 5:18 PM, Drew Wilson <[email protected]> >> wrote: >> > Before we start enforcing penalties for people who screw this up, we >> need to >> > do some tools work to make this less error prone/manual-hackery, I >> think. >> > -atw >> > >> > On Thu, Sep 24, 2009 at 1:56 PM, Steve Vandebogart < >> [email protected]> >> > wrote: >> >> >> >> On Thu, Sep 24, 2009 at 1:49 PM, Yaar Schnitman <[email protected]> >> wrote: >> >>> >> >>> Yes. >> >>> With git: >> >>> git try -b <bot> --webkit <webkit branch> <chromium branch> >> >>> With gcl: >> >>> Manually create a patch by concatenating two (chromium + webkit) >> patches. >> >>> Make sure that the webkit patches have the right prefixes by using >> >>> --src-prefix=src/third_party/WebKit >> --dst-prefix=src/third_party/WebKit on >> >>> your diff command. >> >>> On Thu, Sep 24, 2009 at 1:43 PM, Jeremy Orlow <[email protected]> >> >>> wrote: >> >>>> >> >>>> On Tue, Sep 22, 2009 at 6:35 PM, Adam Barth <[email protected]> >> wrote: >> >>>>> >> >>>>> On Tue, Sep 22, 2009 at 6:25 PM, John Abd-El-Malek < >> [email protected]> >> >>>>> wrote: >> >>>>> > Is this even possible? i.e. I had uploaded a WebKit patch on >> >>>>> > codereview but >> >>>>> > none of the patchsets got run on the try server >> >>>>> > http://codereview.chromium.org/178030/show >> >>>>> >> >>>>> It is possible: >> >>>>> >> >>>>> aba...@zenque:~/svn/kr/src/third_party/WebKit$ gcl try >> scriptcontext >> >>>>> --use_svn --svn_repo=svn://svn.chromium.org/chrome-try/try --bot >> >>>>> layout_win,layout_mac,layout_linux --root src/third_party >> >>>> >> >>>> What about 2 sided patches. Is it possible to test those? >> >> >> >> For gcl, you can also gcl try change -f wekitfile1,webkitfile2,etc. >> You >> >> can also synthesize a change with webkit files by creating a file in >> >> .svn/gcl_info/changes and then gcl try chrome_change,webkit_change. >> >> -- >> >> Steve >> >> >> >> >> >> >> > >> > >> > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
