On Tue, Oct 13, 2009 at 10:31 AM, Dimitri Glazkov <[email protected]>wrote:
> > I think we need to change something. I am not sure what -- I have > ideas, but -- I would appreciate some collective thinking on this. > > PROBLEM: We accumulate more test failures via WebKit rolls than we fix > with our LTTF effort. This ain't right. > > ANALYSIS: > > Ok, WebKit gardening is hard. So is fixing layout tests. You can't > call it a successful WebKit roll if it breaks layout tests. But we > don't revert WebKit rolls. It's a forward-only thing. And we want to > roll quickly, so that we can react to next "big breaker" faster. So > we're stuck with roll-now/clean-up-after deal. This sucks, because the > "clean-up-after" is rarely fully completed. Which brings failing > layout tests, which brings the suffering and spells asymptotic doom to > the LTTF effort. > > POSSIBLE SOLUTIONS: > > * Extend WebKit gardener's duties to 4 days. First two days you roll. > Next two days you fix layout tests. Not file bugs -- actually fix > them. The net result of 4 days should be 0 (or less!) new layout test > failures. This solution kind of expects the gardener to be part of > LTTF, which is not always the case. So it may not seem totally fair. > Putting everything you're doing on hold for 2 days while gardening is hard enough. 4 days is just not feasible most of the time. I like the idea that more of us try to understand and fix more code, but there are some times when it just doesn't make sense for the gardener to fix stuff. Also, if a team of people can't seem to keep up, then how is 1 person going to keep up??? Unless the reason we can't keep up is that our priorities are not straight. In which case, that's what we should be fixing. > * Assign LTTF folks specifically for test clean-up every day. The idea > here is to slant LTTF effort aggressively toward fixing newer > failures. This seems nice for the gardeners, but appears to separate > the action/responsibility dependency: no matter what you roll, the > LTTF elves will fix it. > I think it's best to keep LTTF just looking at the problems that have plagued us for a long time. What about having 2 people on the gardener rotation looking at layout test failures each day. In other words, the gardeners will create the bugs and pass them to a dedicated triaging and fixing team. The team will only assign a bug to someone else only if it's beyond their ability to figure out. And, when they do so, it'll be a P1 or P0. > > * [ your idea goes here ] > > TIMELINE: > > I would like for us to agree on a solution and make the necessary > changes to the process today. Tomorrow is a new day, full of > surprising changes upstream. > Being aggressive and fixing problems is good, but I don't see why this is an emergency. Maybe targeting end of week is a better, more realistic goal. --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
