On Thu, Sep 8, 2011 at 5:40 AM, Paul Taggart <ptagg...@cinci.rr.com> wrote:
> Octavio,
>
> How would you propose addressing this issue? I split my monster patch file
> and reduced it to 31437 lines (roughly 60,000 lines of the patch turned out
> to be gettext data that didn't get erased in a make clean) to just insert
> "(char *)" on the 6727 lines of code producing this warning (yes, I
> counted). String constants are a fact of life and making everything
> modifiable is impractical. Just by masking the Char * warnings, I found a
> handful of compiler warnings that pointed to real problems(I will be
> submitting those patches soon).
>
Most of the warnings come from constructs like this:
int fn(char *s)
{
....
}
......
x = fn("a string");
Correct fix is to replace fn with 'int fn(const char *s)'
This is correct way. And much less changes. I have alreday done this
in my tree. (look at commits around 2010-03-12 in my tree).
Einar
_______________________________________________
Cinelerra mailing list
Cinelerra@skolelinux.no
https://init.linpro.no/mailman/skolelinux.no/listinfo/cinelerra
