Hi Chandra and Kurosawa-san, Chandra Seetharaman wrote: > Hi MAEDA, > > Cool... thanks, i 'll have a look and try it out. > > One generic comment, it will be better if you could separate the CKRM > functionality (most of your patch) to a separate file and place it in > the ckrm directory rather than adding to the cpr_rc.c file in the kernel > directory.
It requires some changes of Kurosawa-san's code structure to do so. I've never tried it, but at least struct cpu_rc_domain, struct cpu_rc and some static inline functions must be moved to cpu_rc.h. Kurosawa-san, how do you think these changes against your code? Obviously this change may also affects your cpumeter interface code. > chandra > On Fri, 2005-10-07 at 17:37 +0900, MAEDA Naoaki wrote: > >>Hello Kurosawa-san and Chandra, >> >>I finished to connect kurosawa-san's cpu resource controller >>with f0.2 ckrm. This patch is against 2.6.13+ckrm-f0.2 with the >>CPU resource controller patch has been posted to LKML by Kurosawa-san. >> >>I attached the CPU resource controller patch for convenience, and >>I also attached a temporary ckrm bug fix patch to correct some problems >>I've reported to the [EMAIL PROTECTED] >> >>Notice that removing class is not tested yet, because the res_free >>callback is not called even if a class is removed. I doubt it is >>another bug of f series ckrm core. > > > The patch I posted on Sep 30th with the subject > > > "[PATCH]: f0.2 do not kref_get in > ckrm_alloc_class" > > should take care of this problem Oh! I've missed the mail. The problem has gone after applying the patch. p.s. Sorry for the subject line contains mis-spelling - grue should be glue. The pronunciation of 'l' and 'r' is interchangeable for me :-P Thanks, MAEDA Naoaki ------------------------------------------------------- This SF.Net email is sponsored by: Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl _______________________________________________ ckrm-tech mailing list https://lists.sourceforge.net/lists/listinfo/ckrm-tech
