Joseph> Oops, it's actually at ftp://fencepost.gnu.org/fsf/diff.txt
Joseph> When it came to uploading it gnu looked too official.
Is this just a reformatting patch? I looked at it briefly. Parts are
wrong. For instance, the StringBuffer change can't be right, because
the code in question already follows the coding standard.
I disagree. For example the area in the if statement around line 291 should
be inset 2 spaces from the if's position. This is not just a reformatting
patch, however, enough reformatting occurred that it is difficult to see
the changes that are comment edits.
I didn't
check the other parts too closely; some look wrong to me but I can't
be sure because diffs often look wrong with respect to whitespace
until they are actually applied...
Tom
Here's what I did:
I ran the entire directory through indent. I did this because a. I knew
that it was designed according to the GNU standards and b. to get all the
files to look the same in a way that could be used on the rest of the
project. There are a few problems that I ran into, indent moved some of the
"0.0d"'s in Double over a space from the number, screwing up the
compile. The other (very minor) problem is that indent is for C and as such
has a hard time putting spaces in for compound function calls. However, I
fixed the thing in Double in 30 seconds and the rest, while a little odd,
is consistent and easily reproducible by anyone with indent on their
system.
Then I went through each file and read all the comments (ok, I skimmed some
of the repetitive stuff :) and edited those that I felt needed it. A lot of
the work was adding code tags.
Joey
