Tom> For instance, the StringBuffer change can't be right, because the
Tom> code in question already follows the coding standard.
Joseph> I disagree. For example the area in the if statement around
Joseph> line 291 should be inset 2 spaces from the if's position.
I'm not sure I understand.
Here is what I see:
if (shared || minimumCapacity > value.length)
{
// We don't want to make a larger vector when `shared' is
// set. If we do, then setLength becomes very inefficient
// when repeatedly reusing a StringBuffer in a loop.
int max = (minimumCapacity > value.length
? value.length*2+2
: value.length);
For the same of the mail system I've replace tabs with spaces.
Which line do you think is wrong here? How do you think it should
look? By my reading of the GNU coding standards, this code is
correctly indented.
Joseph> This is not just a reformatting patch, however, enough
Joseph> reformatting occurred that it is difficult to see the changes
Joseph> that are comment edits.
I personally prefer to have reformatting separate from more
substantive changes.
Joseph> There are a few problems that I ran into, indent moved some of
Joseph> the "0.0d"'s in Double over a space from the number, screwing
Joseph> up the compile.
There is a Java indent program on sourceforge that might be more
useful than the C indent.
Tom
