Cc: [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED]
X-Zippy: Yow! Are we laid back yet?
From: Tom Tromey <[EMAIL PROTECTED]>
Date: 27 Jul 2000 20:16:31 -0600
Tom> For instance, the StringBuffer change can't be right, because the
Tom> code in question already follows the coding standard.
Joseph> I disagree. For example the area in the if statement around
Joseph> line 291 should be inset 2 spaces from the if's position.
I'm not sure I understand.
Here is what I see:
if (shared || minimumCapacity > value.length)
{
// We don't want to make a larger vector when `shared' is
// set. If we do, then setLength becomes very inefficient
// when repeatedly reusing a StringBuffer in a loop.
int max = (minimumCapacity > value.length
? value.length*2+2
: value.length);
For the same of the mail system I've replace tabs with spaces.
Which line do you think is wrong here? How do you think it should
look? By my reading of the GNU coding standards, this code is
correctly indented.
Ahh, it's the tabs that are doing it. Using tabs makes life funny for each
reader, especially when using Emacs which lets you choose what a tab
means. When I look at it it seems that the body of the if actually starts
two characters to the *left* of the if itself. I think this is a moot point
as my change only changes the tab to spaces garunteeing reader
portability.
Joseph> This is not just a reformatting patch, however, enough
Joseph> reformatting occurred that it is difficult to see the changes
Joseph> that are comment edits.
I personally prefer to have reformatting separate from more
substantive changes.
So do I. I was a little stupid about it. I had already started making
changes when it really dawned on me how different people's styles were and
so for the sake of my sanity (13,000 lines is a pretty decent amount of
code to read) I ran it through indent. I won't make that mistake again.
Joseph> There are a few problems that I ran into, indent moved some of
Joseph> the "0.0d"'s in Double over a space from the number, screwing
Joseph> up the compile.
There is a Java indent program on sourceforge that might be more
useful than the C indent.
Cool, I'll try it out and post to let people criticize the results. Thanks
for pointing that out.
-- Joey
+-------------------------------------------------------+
http://www.cs.grinnell.edu/~lesh
[EMAIL PROTECTED] [EMAIL PROTECTED] [EMAIL PROTECTED]
1 + 1 = 3, for large values of 1.
+-------------------------------------------------------+
