I reviewed the changes for NWAM, SMF, install/bfu/upgrade and other.
The work looks to be very well done, as I only found one issue where
a change in the net-physical start method appears to be needed in
the net-nwam method as well, plus some nits in bfu.sh:

* cmd/svc/milestone/net-physical

  Isn't the purge-phys change also needed in net-nwam?

* tools/scripts/bfu.sh

  * 632: typo: s/admnistrator/administrator/
  * 657: typo: extra #
  * 659: should this be "((i = i + 1))"?
  * 649,658,660,663,685: unnecessary use of {}
  * 1963-1973: this should not be necessary, as Nevada bfu is supposed
    to assume a baseline of S10 FCS which includes SMF

-- John

http://blogs.sun.com/jbeck

Reply via email to